Re: [PATCH v2] dpll: zl3073x: fix kernel-doc name and missing parameter in fw.c

[Ivan Vecera]

On 11/12/25 6:56 AM, Kriish Sharma wrote:
> Documentation build reported:
>
>    Warning: drivers/dpll/zl3073x/fw.c:365 function parameter 'comp' not described in 'zl3073x_fw_component_flash'
>    Warning: drivers/dpll/zl3073x/fw.c:365 expecting prototype for zl3073x_flash_bundle_flash(). Prototype was for zl3073x_fw_component_flash() instead
>    Warning: drivers/dpll/zl3073x/fw.c:365 No description found for return value of 'zl3073x_fw_component_flash'
>
> The kernel-doc comment above `zl3073x_fw_component_flash()` used the wrong
> function name (`zl3073x_flash_bundle_flash`) and omitted the `@comp` parameter.
> This patch updates the comment to correctly document the
> `zl3073x_fw_component_flash()` function and its arguments.
>
> Fixes: ca017409da69 ("dpll: zl3073x: Add firmware loading functionality")
> Signed-off-by: Kriish Sharma <kriish.sharma2006@xxxxxxxxx>
> ---
> v2:
>   - Added colon to fix kernel-doc warning for `Return:` line.
>
> v1: https://lore.kernel.org/all/20251110195030.2248235-1-kriish.sharma2006@xxxxxxxxx
>
>   drivers/dpll/zl3073x/fw.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dpll/zl3073x/fw.c b/drivers/dpll/zl3073x/fw.c
> index def37fe8d9b0..55b638247f4b 100644
> --- a/drivers/dpll/zl3073x/fw.c
> +++ b/drivers/dpll/zl3073x/fw.c
> @@ -352,12 +352,12 @@ struct zl3073x_fw *zl3073x_fw_load(struct zl3073x_dev *zldev, const char *data,
>   }
>   
>   /**
> - * zl3073x_flash_bundle_flash - Flash all components
> + * zl3073x_fw_component_flash - Flash all components
>    * @zldev: zl3073x device structure
> - * @components: pointer to components array
> + * @comp: pointer to components array
>    * @extack: netlink extack pointer to report errors
>    *
> - * Returns 0 in case of success or negative number otherwise.
> + * Return: 0 in case of success or negative number otherwise.
>    */

Reviewed-by: Ivan Vecera <ivecera@xxxxxxxxxx>