Re: [PATCH v7 0/2] rust: leds: add led classdev abstractions

[Markus Probst]

On Thu, 2025-11-13 at 15:20 +0100, Markus Probst wrote:
> On Mon, 2025-10-27 at 20:06 +0000, Markus Probst wrote:
> > This patch series has previously been contained in
> > https://lore.kernel.org/rust-for-linux/20251008181027.662616-1-markus.probst@xxxxxxxxx/T/#t
> > which added a rust written led driver for a microcontroller via i2c.
> > 
> > As the reading and writing to the i2c client via the register!
> > macro has not been implemented yet [1], the patch series will only
> > contain the additional abstractions required.
> > 
> > [1] https://lore.kernel.org/rust-for-linux/DDDS2V0V2NVJ.16ZKXCKUA1HUV@xxxxxxxxxx/
> > 
> > The following changes were made:
> > * add abstraction to convert a device reference to a bus device
> >   reference for use in class device callbacks
> > 
> > * add basic led classdev abstractions to register and unregister leds
> > 
> > Changes since v6:
> > * fixed typos
> > * improved documentation
> > 
> > Changes since v5:
> > * rename `IntoBusDevice` trait into `AsBusDevice`
> > * fix documentation about `LedOps::BLOCKING`
> > * removed dependency on i2c bindings
> > * added `AsBusDevice` implementation for `platform::Device`
> > * removed `device::Device` fallback implementation
> > * document that `AsBusDevice` must not be used by drivers and is
> >   intended for bus and class device abstractions only.
> > 
> > Changes since v4:
> > * add abstraction to convert a device reference to a bus device
> >   reference
> > * require the bus device as parent device and provide it in class device
> >   callbacks
> > * remove Pin<Vec<_>> abstraction (as not relevant for the led
> >   abstractions)
> > * fixed formatting in `led::Device::new`
> > * fixed `LedOps::BLOCKING` did the inverse effect
> > 
> > Changes since v3:
> > * fixed kunit tests failing because of example in documentation
> > 
> > Changes since v2:
> > * return `Devres` on `led::Device` creation
> > * replace KBox<T> with T in struct definition
> > * increment and decrement reference-count of fwnode
> > * make a device parent mandatory for led classdev creation
> > * rename `led::Handler` to `led::LedOps`
> > * add optional `brightness_get` function to `led::LedOps`
> > * use `#[vtable]` instead of `const BLINK: bool`
> > * use `Opaque::cast_from` instead of casting a pointer
> > * improve documentation
> > * improve support for older rust versions
> > * use `&Device<Bound>` for parent
> > 
> > Changes since v1:
> > * fixed typos noticed by Onur Özkan
> > 
> > Markus Probst (2):
> >   rust: Add trait to convert a device reference to a bus device
> >     reference
> >   rust: leds: add basic led classdev abstractions
> > 
> > Markus Probst (2):
> >   rust: Add trait to convert a device reference to a bus device
> >     reference
> >   rust: leds: add basic led classdev abstractions
> 
> Hi,
> 
> So you know in advance, I will add a 3. patch for multicolor led
> classdev abstractions (drivers/leds/led-class-multicolor.c,
> include/linux/led-class-multicolor.h) to this patch series.
> 
> In the atmega1608 led driver (the user of these abstractions) there are
> leds with different colors that share the same slot.
> Technically "drivers/leds/rgb/leds-group-multicolor.c" could be used in
> combination with single color leds instead, but then hardware
> accelerated blinking wouldn't be supported. I think it would make more
> sense to directly implement it in the driver.
> 
> The existing 2 patches shouldn't change, so feel free to review them.
> 
> Thanks
> - Markus Probst

ignore the duplicate email. Sending the email gave an error, retrying
resulted in the email being sent twice.

Thanks
- Markus Probst

> 
> > 
> >  rust/kernel/auxiliary.rs |   7 +
> >  rust/kernel/device.rs    |  33 ++++
> >  rust/kernel/led.rs       | 375 +++++++++++++++++++++++++++++++++++++++
> >  rust/kernel/lib.rs       |   1 +
> >  rust/kernel/pci.rs       |   7 +
> >  rust/kernel/platform.rs  |   7 +
> >  rust/kernel/usb.rs       |   6 +
> >  7 files changed, 436 insertions(+)
> >  create mode 100644 rust/kernel/led.rs