Re: [PATCH net] net: dsa: hellcreek: fix missing error handling in LED registration

From: Kurt Kanzenbach

Date: Thu Nov 13 2025 - 09:24:35 EST


On Thu Nov 13 2025, Pavel Zhigulin wrote:
> The LED setup routine registered both led_sync_good
> and led_is_gm devices without checking the return
> values of led_classdev_register(). If either registration
> failed, the function continued silently, leaving the
> driver in a partially-initialized state and leaking
> a registered LED classdev.
>
> Add proper error handling
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 7d9ee2e8ff15 ("net: dsa: hellcreek: Add PTP status LEDs")
> Signed-off-by: Pavel Zhigulin <Pavel.Zhigulin@xxxxxxxxxxxxx>

Acked-by: Kurt Kanzenbach <kurt@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature