Re: [PATCH v5] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride

[Konrad Dybcio]

On 11/13/25 6:51 AM, Wei Zhang wrote:
> Enable WLAN on qcs8300-ride by adding a node for the PMU module
> of the WCN6855 and assigning its LDO power outputs to the existing
> WiFi module.
> 
> On the qcs8300-ride platform, the corresponding firmware and BDF
> are QCA6698AQ instead of WCN6855, which have been added in the
> 20250211 release.
> 
> Signed-off-by: Wei Zhang <wei.zhang@xxxxxxxxxxxxxxxx>
> ---

[...]

> +		wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;

You say active-high here

[...]

> +	wlan_en_state: wlan-en-state {
> +		pins = "gpio54";
> +		function = "gpio";
> +		bias-pull-up;
> +		output-low;

and active-low here..

Please remove the latter line

Konrad