Re: [PATCH v1] nvmem: core: update cell->bytes after shifting bits

[Emil Renner Berthing]

Quoting Srinivas Kandagatla (2025-11-10 09:32:08)
>
>
> On 9/30/25 3:22 PM, Emil Renner Berthing wrote:
> > When support for bit offsets of more than one byte was added it
> > unfortunately left the cell->bytes value at the number of bytes read
> > including the offset. Make sure to update it to the proper number of
> > meaningful bytes in the returned data.
> Sorry somehow I missed this patch.
>
> If the number of bytes are different to the bytes that are part of cell
> then the parsing code seems to have missed some cases, which is the
> right place to fix.
>
> Can you share more details on the values that you pass as part of the
> cell definition.

Yes, the node effectively looks like this:

sid: efuse@3006000 {
        compatible = "allwinner,sun20i-d1-sid";
        reg = <0x3006000 0x1000>;
        #address-cells = <1>;
        #size-cells = <1>;

        ths_calib: ths-calib@14 {
                reg = <0x14 0x4>;
        };

        bg_trim: bg-trim@28 {
                reg = <0x28 0x4>;
                bits = <16 8>;
        };
};

/Emil