Re: [PATCH RFC 2/8] media: qcom: camss: csiphy: Introduce C-PHY

From: Bryan O'Donoghue

Date: Thu Nov 13 2025 - 04:28:00 EST


On 12/11/2025 16:15, David Heidelberg wrote:
Should be an integer from

include/dt-bindings/phy/phy.h

- PHY_TYPE_DPHY
- PHY_TYPE_CPHY

this should be indicated in the dt and latched here.

Would it make sense to rather use the int from:

include/dt-bindings/media/video-interfaces.h

 - MEDIA_BUS_TYPE_CSI2_CPHY
 - MEDIA_BUS_TYPE_CSI2_DPHY
 - ...

?
Maybe, but surely you need to get the mode of the PHY from DT ?

I'm fine with the MEDIA_BUS_TYPE but, I do think the logic must be DT driven.

---
bod