Re: [PATCH v5 06/14] smb/server: remove create_durable_reconn_req

[ChenXiaoSong]

Hi Namjae,

Please do not apply patch 0007 yet.

The struct smb_hdr seems to be used only by SMB1, while SMB2 and SMB3 
use smb2_hdr.

Should we move smb_hdr to a new common/smb1pdu.h?

Thanks,
ChenXiaoSong.

On 11/13/25 10:12 AM, Namjae Jeon wrote:
> On Thu, Nov 13, 2025 at 10:46 AM ChenXiaoSong
> <chenxiaosong@xxxxxxxxxxxxxxxx> wrote:
> > Okay, I'll make the changes.
> >
> > Once you've applied some of the patches from this version, I'll
> > immediately send the next version.
> I have applied all patches except 0006, 0012 patches to #ksmbd-for-next-next.
> Thanks!
> > Thanks,
> > ChenXiaoSong.
> >
> > On 11/13/25 9:19 AM, Namjae Jeon wrote:
> > > On Sun, Nov 2, 2025 at 4:32 PM <chenxiaosong.chenxiaosong@xxxxxxxxx> wrote:
> > > > From: ChenXiaoSong <chenxiaosong@xxxxxxxxxx>
> > > >
> > > > The fields in struct create_durable_reconn_req and struct create_durable
> > > > are exactly the same.
> > > >
> > > > The documentation references are:
> > > >
> > > >     - SMB2_CREATE_DURABLE_HANDLE_REQUEST   in MS-SMB2 2.2.13.2.3
> > > >     - SMB2_CREATE_DURABLE_HANDLE_RECONNECT in MS-SMB2 2.2.13.2.4
> > > >     - SMB2_FILEID in MS-SMB2 2.2.14.1
> > > >
> > > > We can give these two structs a uniform name: create_durable.
> > > Please use typedef to define multiple aliases for a single struct.
> > > typedef struct {
> > >     ...
> > > } create_durable, create_durable_reconn_req;
> > >
> > > Thanks.