Re: [PATCH] hwmon: (gpd-fan) Fix the compilation error
From: Guenter Roeck
Date: Wed Nov 12 2025 - 15:03:47 EST
On 11/11/25 19:09, Cryolitia PukNgae wrote:
On 12/11/2025 09.57, luoqing wrote:Yes, I'll just need to send the pull request.
From: luoqing <luoqing@xxxxxxxxxx>
drivers/hwmon/gpd-fan.c: in the function 'gpd_ecram_read' :
drivers/hwmon/gpd-fan.c:231:9: Error: implicit declaration function 'outb' [-Werror= implrecental-function-declaration]
231 | outb(0x2E, addr_port);
^~~~
drivers/hwmon/gpd-fan.c:244:16: Error: implicit declaration function 'inb' [-Werror= implrecental-function-declaration]
244 | *val = inb(data_port);
^~~
cc1: All warnings were regarded as errors
Signed-off-by: luoqing <luoqing@xxxxxxxxxx>
---
drivers/hwmon/gpd-fan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
index 321794807e8d..57d4ee683f0d 100644
--- a/drivers/hwmon/gpd-fan.c
+++ b/drivers/hwmon/gpd-fan.c
@@ -19,6 +19,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/platform_device.h>
+#include <linux/io.h>
#define DRIVER_NAME "gpdfan"
#define GPD_PWM_CTR_OFFSET 0x1841
Has it already been fixed in it[1] ?
1. https://lore.kernel.org/all/20251024202042.752160-1-krishnagopi487@xxxxxxxxx/#t
Guenter