Re: [PATCH v2] ASoC: Intel: avs: Fix potential buffer overflow by snprintf()

[Greg KH]

On Wed, Nov 12, 2025 at 11:48:51PM +0530, hariconscious@xxxxxxxxx wrote:
> From: HariKrishna Sagala <hariconscious@xxxxxxxxx>
> 
> snprintf() returns the would-be-filled size when the string overflows
> the given buffer size, hence using this value may result in a buffer
> overflow (although it's unrealistic).

unrealistic == impossible

So why make this change at all?

> This patch replaces it with a safer version, scnprintf() for papering
> over such a potential issue.

Don't "paper over", actually fix real things.


> Link: https://github.com/KSPP/linux/issues/105
> 'Fixes: 5a565ba23abe ("ASoC: Intel: avs: Probing and firmware tracing
> over debugfs")'

No, this is not a "fix".

Also please do not wrap lines of fixes tags.

thanks,

greg k-h