Re: [PATCH] x86/acpi/boot: Correct acpi_is_processor_usable() check again

From: Borislav Petkov

Date: Wed Nov 12 2025 - 14:17:59 EST


On Wed, Nov 12, 2025 at 07:05:18PM +0100, Michal Pecio wrote:
> Nitpick: IMO logic would be easier to follow if written this way:
>
> if (lapic_flags & ACPI_MADT_ENABLED)
> return true;
>
> if (acpi_support_online_capable)
> return lapic_flags & ACPI_MADT_ONLINE_CAPABLE;
>
> /* we should say 'no' at this point, but VMs are crazy */
> return !hypervisor_is_type(X86_HYPER_NATIVE);

Sure, except I'd like to keep the original comment as that leaves more
breadcrumbs about why we're doing this insanity.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette