Re: [PATCH 1/2] dt-bindings: regulator: pca9540: add debounce timer configuration

[Conor Dooley]

On Wed, Nov 12, 2025 at 01:17:08PM +0100, Martijn de Gouw wrote:
> Make the different debounce timers configurable from the devicetree.
> Depending on the board design, these have to be set different than the
> default register values.
> 
> Signed-off-by: Martijn de Gouw <martijn.de.gouw@xxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  .../regulator/nxp,pca9450-regulator.yaml      | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> index a5486c36830f0..e49acadabc4b0 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml
> @@ -124,6 +124,36 @@ properties:
>        When WDOG_B signal is asserted a warm reset will be done instead of cold
>        reset.
>  
> +  nxp,pmic_on_req-on-debounce-us:

While you're solving the bot complaints, replace the _s with -s.

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [ 120, 20000, 100000, 750000 ]
> +    description: Debounce time for PMIC_ON_REQ high.
> +
> +  nxp,pmic_on_req-off-debounce-us:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [ 120, 2000 ]
> +    description: Debounce time for PMIC_ON_REQ is asserted low

These enum values are kinda strange. The only two options are 120 and
2000 or are those max and min? Not super suspect since there's partial
matching with the req-on property but weird enough to ask about ;)

> +
> +  nxp,power-on-step-ms:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [ 1, 2, 4, 8]
> +    description: Time step configuration during power on sequence
> +
> +  nxp,power-down-step-ms:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [ 2, 4, 8, 16 ]
> +    description: Time step configuration during power down sequence
> +
> +  nxp,restart-ms:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [ 250, 500 ]
> +    description: Time to stay off regulators during Cold reset
> +
> +  npx,pmic_rst_b-debounce-ms:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [ 10, 50, 100, 500, 1000, 2000, 4000, 8000 ]
> +    description: PMIC_RST_B debounce time
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.39.2
>

Attachment: signature.asc
Description: PGP signature