Re: mempool_alloc_bulk and various mempool improvements

From: Eric Biggers

Date: Wed Nov 12 2025 - 12:34:07 EST


On Wed, Nov 12, 2025 at 04:50:11PM +0100, Christoph Hellwig wrote:
> On Wed, Nov 12, 2025 at 01:22:01PM +0100, Vlastimil Babka wrote:
> > On 11/11/25 14:52, Christoph Hellwig wrote:
> > > Hi all,
> > >
> > > this series adds a bulk version of mempool_alloc that makes allocating
> > > multiple objects deadlock safe.
> > >
> > > The initial users is the blk-crypto-fallback code:
> > >
> > > https://lore.kernel.org/linux-block/20251031093517.1603379-1-hch@xxxxxx/
> > >
> > > with which v1 was posted, but I also have a few other users in mind.
> >
> > How do we handle this then once it's settled?
>
> Good question. I think there is enough mm material now for a merge
> through an mm tree. If we get it sorted out for this merge window just
> merging it through mm even when there is no user yet would be easiest as
> the blk-crypto work is probably not going to make this merge window with
> additional review from Eric and I'll most like have another user for the
> next merge window as well (block bounce buffering for !STABLE_WRITES
> dio).

That sounds good to me. Sorry for the slow review on the
blk-crypto-fallback changes. How about I also take the two fscrypt
cleanups "fscrypt: pass a real sector_t to
fscrypt_zeroout_range_inline_crypt" and "fscrypt: keep multiple bios in
flight in fscrypt_zeroout_range_inline_crypt" through the fscrypt tree
for 6.19 to get them out of the way? They don't depend on anything
else.

- Eric