Re: [PATCH 1/3] drm/virtio: support VIRTIO_GPU_F_BLOB_ALIGNMENT

[Sergio Lopez Pascual]

Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> writes:

> On 11/10/25 15:52, Sergio Lopez wrote:
>> +	if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_BLOB_ALIGNMENT)) {
>> +		vgdev->has_blob_alignment = true;
>> +		virtio_cread_le(vgdev->vdev, struct virtio_gpu_config,
>> +				blob_alignment, &blob_alignment);
>> +		vgdev->blob_alignment = blob_alignment;
>
> Shouldn't blob_alignment be max(guest_alignment, host_alignment)?

virtio_gpu_config is the minimum alignment required by the device/host.
If the guest requires a higher alignment than the device/host, I would
expect that to be found by a different mechanism, as it would happen on
gpu drivers other than virtio-gpu.

Sergio.