Re: [PATCH v2] gpio: menz127: add support for 16Z034 and 16Z037 GPIO controllers

[Krzysztof Kozlowski]

On 11/11/2025 17:18, Jose Javier Rodriguez Barbarin wrote:
>  
>  static const struct mcb_device_id men_z127_ids[] = {
> -	{ .device = 0x7f },
> +	{ .device = MEN_Z127_ID },
> +	{ .device = MEN_Z034_ID },
> +	{ .device = MEN_Z037_ID },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(mcb, men_z127_ids);
> @@ -204,4 +224,6 @@ MODULE_AUTHOR("Andreas Werner <andreas.werner@xxxxxx>");
>  MODULE_DESCRIPTION("MEN 16z127 GPIO Controller");
>  MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("mcb:16z127");
> +MODULE_ALIAS("mcb:16z034");
> +MODULE_ALIAS("mcb:16z037");

Why do you need these? You have MODULE_DEVICE_TABLE() just few lines above.

>  MODULE_IMPORT_NS("MCB");


Best regards,
Krzysztof