Re: [PATCH] drivers/greybus: add WQ_PERCPU to alloc_workqueue users

[Marco Crivellari]

Hi,

On Wed, Nov 12, 2025 at 4:00 PM Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> Please use just
>
>         greybus:
>
> as prefix.

I will do it, thanks. I think I saw a couple of commits with that
prefix, so I used
it. I could have looked better.

>
> On Fri, Nov 07, 2025 at 02:21:49PM +0100, Marco Crivellari wrote:
> > Currently if a user enqueues a work item using schedule_delayed_work() the
> > used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> > WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> > schedule_work() that is using system_wq and queue_work(), that makes use
> > again of WORK_CPU_UNBOUND.
> > This lack of consistency cannot be addressed without refactoring the API.
>
> Apart from the naming of the WORK_CPU_UNBOUND macro I don't see the
> inconsistency here. We queue on the local CPU as documented (unless the
> CPU is not in the wq_unbound cpumask for unbound workqueues).
>
> Note sure how explicitly marking percpu workqueues is going to change
> this either so this paragraph doesn't seem relevant for the change at
> hand.

That part is there only to give more context, but I can remove it from the log.
I can start directly mentioning the changes in the workqueue API.

> Fair enough, the default is about to be changed.

For now we're only making explicit if a workqueue is per-cpu or not.
But yes, in the future, this will change.

> > Suggested-by: Tejun Heo <tj@xxxxxxxxxx>
> > Signed-off-by: Marco Crivellari <marco.crivellari@xxxxxxxx>
>
> With an updated commit message you can add my:
>
> Reviewed-by: Johan Hovold <johan@xxxxxxxxxx>

I will send the v2 changing the log and adding your tag.

Thanks!


-- 

Marco Crivellari

L3 Support Engineer, Technology & Product