Re: [PATCH net-next v4 12/12] selftests/vsock: disable shellcheck SC2317 and SC2119

[Stefano Garzarella]

On Sat, Nov 08, 2025 at 08:01:03AM -0800, Bobby Eshleman wrote:
> From: Bobby Eshleman <bobbyeshleman@xxxxxxxx>
>
> Disable shellcheck rules SC2317 and SC2119. These rules are being
> triggered due to false positives. For SC2317, many `return
> "${KSFT_PASS}"` lines are reported as unreachable, even though they are
> executed during normal runs. For SC2119, the fact that
> log_guest/log_host accept either stdin or arguments triggers SC2119,
> despite being valid.
>
> Signed-off-by: Bobby Eshleman <bobbyeshleman@xxxxxxxx>
> ---
> tools/testing/selftests/vsock/vmtest.sh | 2 ++
> 1 file changed, 2 insertions(+)

Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>

> diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh
> index 42e155b45602..c7b270dd77a9 100755
> --- a/tools/testing/selftests/vsock/vmtest.sh
> +++ b/tools/testing/selftests/vsock/vmtest.sh
> @@ -7,6 +7,8 @@
> #		* virtme-ng
> #		* busybox-static (used by virtme-ng)
> #		* qemu	(used by virtme-ng)
> +#
> +# shellcheck disable=SC2317,SC2119
>
> readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
> readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)
>
> --
> 2.47.3