Re: [PATCH] samples: rust: fix endianness issue in rust_driver_pci
From: Dirk Behme
Date: Wed Nov 12 2025 - 05:17:28 EST
On 12/11/2025 10:37, Miguel Ojeda wrote:
On Wed, Nov 12, 2025 at 9:47 AM Marko Turk <mt@xxxxxxxxxxxxxx> wrote:
On Sat, Nov 01, 2025 at 10:46:54PM +0100, Marko Turk wrote:
QEMU PCI test device specifies all registers as little endian. OFFSET
register is converted properly, but the COUNT register is not.
Apply the same conversion to the COUNT register also.
Signed-off-by: Marko Turk <mt@xxxxxxxxxxxxxx>
Fixes: 685376d18e9a ("samples: rust: add Rust PCI sample driver")
Can someone take a look?
Your message was in my spam folder -- that may be affecting who saw it.
From https://www.qemu.org/docs/master/specs/pci-testdev.html:
"All registers are little endian."
So this seems right. A couple tags:
Cc: stable@xxxxxxxxxxxxxxx
Link: https://www.qemu.org/docs/master/specs/pci-testdev.html
Cc'ing Dirk, since he tested the sample originally.
Hmm, I can't find the initial patch in my Inbox. Even
https://lore.kernel.org/rust-for-linux/aRRJPZVkCv2i7kt2@xxxxxxxxxxxxxxxxxx/
doesn't seem to have it?
Thanks
Dirk