Re: [PATCH] samples: rust: fix endianness issue in rust_driver_pci
From: Miguel Ojeda
Date: Wed Nov 12 2025 - 04:37:35 EST
On Wed, Nov 12, 2025 at 9:47 AM Marko Turk <mt@xxxxxxxxxxxxxx> wrote:
>
> On Sat, Nov 01, 2025 at 10:46:54PM +0100, Marko Turk wrote:
> > QEMU PCI test device specifies all registers as little endian. OFFSET
> > register is converted properly, but the COUNT register is not.
> >
> > Apply the same conversion to the COUNT register also.
> >
> > Signed-off-by: Marko Turk <mt@xxxxxxxxxxxxxx>
> > Fixes: 685376d18e9a ("samples: rust: add Rust PCI sample driver")
>
> Can someone take a look?
Your message was in my spam folder -- that may be affecting who saw it.
>From https://www.qemu.org/docs/master/specs/pci-testdev.html:
"All registers are little endian."
So this seems right. A couple tags:
Cc: stable@xxxxxxxxxxxxxxx
Link: https://www.qemu.org/docs/master/specs/pci-testdev.html
Cc'ing Dirk, since he tested the sample originally.
Thanks!
Cheers,
Miguel