Re: [RFC PATCH v2 08/23] KVM: x86/tdp_mmu: Alloc external_spt page for mirror page table splitting

[Yan Zhao]

On Tue, Nov 11, 2025 at 05:52:54PM +0800, Huang, Kai wrote:
> On Thu, 2025-08-07 at 17:43 +0800, Yan Zhao wrote:
> > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
> > 
> > Enhance tdp_mmu_alloc_sp_split() to allocate a page for sp->external_spt,
> 	  ^
> 	  tdp_mmu_alloc_sp_for_split()
Right. 

> [...]
> 
> > +static struct kvm_mmu_page *tdp_mmu_alloc_sp_for_split(bool mirror);
> > +
> 
> It doesn't seem you need such declaration in _this_ patch.  If any later
> patch needs it, then perhaps it's better to do in that patch.
Thanks!
I'll drop this declaration. It's no longer needed for v2, because its caller is
now tdp_mmu_split_huge_pages_root(), which is later than
tdp_mmu_alloc_sp_for_split().