Re: [PATCH v2 2/4] nvmet-tcp: Don't free SQ on authentication success

[Hannes Reinecke]

On 11/12/25 00:45, alistair23@xxxxxxxxx wrote:
> From: Alistair Francis <alistair.francis@xxxxxxx>
>
> Curently after the host sends a REPLACETLSPSK we free the TLS keys as
> part of calling nvmet_auth_sq_free() on success. This means when the
> host sends a follow up REPLACETLSPSK we return CONCAT_MISMATCH as the
> check for !nvmet_queue_tls_keyid(req->sq) fails.
>
> This patch ensures we don't free the TLS key on success as we might need
> it again in the future.
>
> Signed-off-by: Alistair Francis <alistair.francis@xxxxxxx>
> ---
> v2:
>   - Don't call nvmet_auth_sq_free() in nvmet_execute_auth_send() either
>
>   drivers/nvme/target/fabrics-cmd-auth.c | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich