Re: [PATCH 2/2] HID: i2c-hid: Add new FocalTech Touchscreen Chip

[Doug Anderson]

Hi,

On Mon, Nov 10, 2025 at 5:35 PM
<daniel_peng@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> From: Daniel Peng <Daniel_Peng@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> Information for touchscreen model HKO/RB116AS01-2 as below:
> - HID :FTSC1000
> - slave address:0X38
> - Interface:HID over I2C
> - Touch control lC:FT8112
> - I2C ID: PNP0C50
>
> Signed-off-by: Daniel Peng <Daniel_Peng@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>
>  drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

The subject of your patch should probably be a little less generic and
include the ID of the chip you're adding support for. Like:

HID: i2c-hid: Add Focaltech FT8112

Other than that, this patch looks fine to me assuming the problems
with your bindings patch get worked out. You may also want to consider
using a different email address for sending since your bindings patch
showed up in my spam folder.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>