Re: [PATCH] tee: qcom: initialize result before use in release worker

[Amirreza Zarrabi]

Hi Sumit,

On 11/11/2025 5:48 PM, Sumit Garg wrote:
> On Mon, Nov 10, 2025 at 01:28:32PM -0800, Amirreza Zarrabi wrote:
> 
> For the subject prefix lets try to follow the directory structure:
> 
> tee: qcomtee: ...
> 

I believe we previously agreed on using tee: qcom: based on the reviewer’s
comments. Currently, there’s no commit message with qcomtee:.

https://lore.kernel.org/op-tee/4rbfpubsaxgv2buksonfigbdkw6geas6l7pycxuukdymqfohga@ohd4hqzvra3w/

Best Regards,
Amir

>> Initialize result to 0 so the error path doesn't read it
>> uninitialized when the invoke fails. Fixes a Smatch warning.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>> Closes: https://lore.kernel.org/op-tee/7c1e0de2-7d42-4c6b-92fe-0e4fe5d650b5@xxxxxxxxxxxxxxxx/
>> Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver")
>> Signed-off-by: Amirreza Zarrabi <amirreza.zarrabi@xxxxxxxxxxxxxxxx>
>> ---
>>  drivers/tee/qcomtee/core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c
>> index b6715ada7700..ecd04403591c 100644
>> --- a/drivers/tee/qcomtee/core.c
>> +++ b/drivers/tee/qcomtee/core.c
>> @@ -82,7 +82,7 @@ static void qcomtee_do_release_qtee_object(struct work_struct *work)
>>  {
>>  	struct qcomtee_object *object;
>>  	struct qcomtee *qcomtee;
>> -	int ret, result;
>> +	int ret, result = 0;
>>  
> 
> The change looks fine to me.
> 
> -Sumit
> 
>>  	/* RELEASE does not require any argument. */
>>  	struct qcomtee_arg args[] = { { .type = QCOMTEE_ARG_TYPE_INV } };
>>
>> ---
>> base-commit: ab40c92c74c6b0c611c89516794502b3a3173966
>> change-id: 20251110-qcom-tee-fix-warning-3d58d74a22d8
>>
>> Best regards,
>> -- 
>> Amirreza Zarrabi <amirreza.zarrabi@xxxxxxxxxxxxxxxx>
>>