Re: [PATCH] perf tools: Fix missing feature check for inherit + SAMPLE_READ

[Ian Rogers]

On Mon, Nov 10, 2025 at 11:59 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> It should also have PERF_SAMPLE_TID to enable inherit and PERF_SAMPLE_READ
> on recent kernels.  Not having _TID makes the feature check wrongly detect
> the inherit and _READ support.
>
> It was reported that the following command failed due to the error in
> the missing feature check on Intel SPR machines.
>
>   $ perf record -e '{cpu/mem-loads-aux/S,cpu/mem-loads,ldlat=3/PS}' -- ls
>   Error:
>   Failure to open event 'cpu/mem-loads,ldlat=3/PS' on PMU 'cpu' which will be removed.
>   Invalid event (cpu/mem-loads,ldlat=3/PS) in per-thread mode, enable system wide with '-a'.
>
> Fixes: 3b193a57baf15c468 ("perf tools: Detect missing kernel features properly")
> Reported-by: "Chen, Zide" <zide.chen@xxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Perhaps also:
Closes: https://lore.kernel.org/lkml/20251022220802.1335131-1-zide.chen@xxxxxxxxx/

Thanks,
Ian

> ---
>  tools/perf/util/evsel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 67a898cda86ab559..989c56d4a23f74f4 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -2474,7 +2474,7 @@ static bool evsel__detect_missing_features(struct evsel *evsel, struct perf_cpu
>         /* Please add new feature detection here. */
>
>         attr.inherit = true;
> -       attr.sample_type = PERF_SAMPLE_READ;
> +       attr.sample_type = PERF_SAMPLE_READ | PERF_SAMPLE_TID;
>         if (has_attr_feature(&attr, /*flags=*/0))
>                 goto found;
>         perf_missing_features.inherit_sample_read = true;
> --
> 2.51.2.1041.gc1ab5b90ca-goog
>