Re: [PATCH] drm/msm/disp: fix kernel-doc warnings

From: Dmitry Baryshkov

Date: Tue Nov 11 2025 - 10:15:34 EST


On Mon, Nov 10, 2025 at 10:03:53PM -0800, Randy Dunlap wrote:
> Fix all kernel-doc warnings in msm_disp_snapshot.h:
>
> msm_disp_snapshot.h:53: warning: Function parameter or struct member
> 'blocks' not described in 'msm_disp_state'
> msm_disp_snapshot.h:69: warning: Function parameter or struct member
> 'node' not described in 'msm_disp_state_block'
> msm_disp_snapshot.h:69: warning: Excess struct member 'drm_dev' description
> in 'msm_disp_state_block'
> msm_disp_snapshot.h:95: warning: No description found for return value
> of 'msm_disp_snapshot_state_sync'
> msm_disp_snapshot.h:100: warning: bad line:
> msm_disp_snapshot.h:117: warning: bad line:
> msm_disp_snapshot.h:125: warning: bad line:
> msm_disp_snapshot.h:142: warning: Excess function parameter 'name'
> description in 'msm_disp_snapshot_add_block'
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> ---
> Cc: Rob Clark <robin.clark@xxxxxxxxxxxxxxxx>
> Cc: Dmitry Baryshkov <lumag@xxxxxxxxxx>
> Cc: Abhinav Kumar <abhinav.kumar@xxxxxxxxx>
> Cc: Jessica Zhang <jesszhan0024@xxxxxxxxx>
> Cc: Sean Paul <sean@xxxxxxxxxx>
> Cc: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: freedreno@xxxxxxxxxxxxxxxxxxxxx
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> ---
> drivers/gpu/drm/msm/disp/msm_disp_snapshot.h | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


--
With best wishes
Dmitry