Re: [PATCH v2 1/2] hfs: Validate CNIDs in hfs_read_inode

Next message: Andy Shevchenko: "[PATCH v1 2/2] devres: Move devm_alloc_percpu() and related to devres.h"
Previous message: Sebastian Andrzej Siewior: "Re: [PATCH v4 2/2] PCI/aer_inject: Convert inject_lock to raw_spinlock_t"
In reply to: Viacheslav Dubeyko: "RE: [PATCH v2 1/2] hfs: Validate CNIDs in hfs_read_inode"
Next in thread: Viacheslav Dubeyko: "RE: [PATCH v2 1/2] hfs: Validate CNIDs in hfs_read_inode"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Tetsuo Handa

Date: Tue Nov 11 2025 - 09:39:46 EST

On 2025/11/04 10:47, George Anthony Vernon wrote:
> + if (!is_valid_cnid(inode->i_ino,
> + S_ISDIR(inode->i_mode) ? HFS_CDR_DIR : HFS_CDR_FIL))
> + BUG();

Is it guaranteed that hfs_write_inode() and make_bad_inode() never run in parallel?
If no, this check is racy because make_bad_inode() makes S_ISDIR(inode->i_mode) == false.