Re: [PATCH v4 2/2] media: i2c: add Sony IMX111 CMOS camera sensor driver

[Svyatoslav Ryhel]

вт, 11 лист. 2025 р. о 15:23 Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> пише:
>
> On Tue, Nov 11, 2025 at 02:53:52PM +0200, Svyatoslav Ryhel wrote:
> > вт, 11 лист. 2025 р. о 14:50 Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> пише:
> > > I can make the two changes before applying, too, if that's ok.
> >
> > If you don't mind adjusting commit on your own before applying I have
> > no objections. Thank you very much!
>
> The diff is:
>
> diff --git a/drivers/media/i2c/imx111.c b/drivers/media/i2c/imx111.c
> index c269e9fdcb0b..8eb919788ef7 100644
> --- a/drivers/media/i2c/imx111.c
> +++ b/drivers/media/i2c/imx111.c
> @@ -1136,13 +1136,6 @@ static int imx111_set_format(struct v4l2_subdev *sd,
>
>         fmt = v4l2_subdev_state_get_format(state, format->pad);
>
> -       fmt->code = imx111_get_format_code(sensor, mbus_fmt->code, false);
> -       fmt->width = mode->width;
> -       fmt->height = mode->height;
> -       fmt->colorspace = V4L2_COLORSPACE_RAW;
> -
> -       *mbus_fmt = *fmt;
> -
>         if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) {
>                 int ret;
>
> @@ -1183,6 +1176,13 @@ static int imx111_set_format(struct v4l2_subdev *sd,
>                         return ret;
>         }
>
> +       fmt->code = imx111_get_format_code(sensor, mbus_fmt->code, false);
> +       fmt->width = mode->width;
> +       fmt->height = mode->height;
> +       fmt->colorspace = V4L2_COLORSPACE_RAW;
> +
> +       *mbus_fmt = *fmt;
> +
>         return 0;
>  }
>
> @@ -1542,9 +1542,9 @@ static int imx111_probe(struct i2c_client *client)
>                 goto error_pm;
>         }
>
> -       pm_runtime_idle(dev);
>         pm_runtime_set_autosuspend_delay(dev, 1000);
>         pm_runtime_use_autosuspend(dev);
> +       pm_runtime_idle(dev);
>
>         return 0;
>
> Hopefully that works!
>

Yes, it seems to work as expected on my device. Thank you.

> --
> Regards,
>
> Sakari Ailus