Re: [PATCH net-next v4 00/12] selftests/vsock: refactor and improve vmtest infrastructure

From: Paolo Abeni

Date: Tue Nov 11 2025 - 07:33:17 EST


On 11/8/25 5:00 PM, Bobby Eshleman wrote:
> This patch series refactors the vsock selftest VM infrastructure to
> improve test run times, improve logging, and prepare for future tests
> which make heavy usage of these refactored functions and have new
> requirements such as simultaneous QEMU processes.
>
> These patches were broken off from this prior series:
> https://lore.kernel.org/all/20251021-vsock-vmtest-v7-0-0661b7b6f081@xxxxxxxx/
>
> To: Stefano Garzarella <sgarzare@xxxxxxxxxx>
> To: Shuah Khan <shuah@xxxxxxxxxx>
> Cc: virtualization@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Cc: linux-kselftest@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Simon Horman <horms@xxxxxxxxxx>
>
> Changes in v4:
> - fix messed up rebase (wrt check_result() and shared_vm_test() patches)
> - more consistent variable quotes style
> - use associative array for pidfiles, remove after terminate
> - Link to v3: https://lore.kernel.org/r/20251106-vsock-selftests-fixes-and-improvements-v3-0-519372e8a07b@xxxxxxxx
>
> Changes in v3:
> - see per-patch changes
> - Link to v2: https://lore.kernel.org/all/20251104-vsock-selftests-fixes-and-improvements-v2-0-ca2070fd1601@xxxxxxxx
>
> Changes in v2:
> - remove "Fixes" for some patches because they do not fix bugs in
> kselftest runs (some fix bugs only when using bash args that kselftest
> does not use or otherwise prepare functions for new usage)
> - broke out one fixes patch for "net"
> - per-patch changes
> - add patch for shellcheck declaration to disable false positives
> - Link to v1: https://lore.kernel.org/r/20251022-vsock-selftests-fixes-and-improvements-v1-0-edeb179d6463@xxxxxxxx

Series LGTM, but let's wait a little bit more for explicit ack from Stefano.

Thanks,

Paolo