Re: [PATCH v6 2/3] spi: spacemit: introduce SpacemiT K1 SPI controller driver

[Alex Elder]

On 10/27/25 8:46 PM, Troy Mitchell wrote:
> On Mon, Oct 27, 2025 at 07:55:02AM -0500, Alex Elder wrote:
> > This patch introduces the driver for the SPI controller found in the
> > SpacemiT K1 SoC.  Currently the driver supports master mode only.
> > The SPI hardware implements RX and TX FIFOs, 32 entries each, and
> > supports both PIO and DMA mode transfers.
> >
> > Signed-off-by: Alex Elder <elder@xxxxxxxxxxxx>
> > ---
> >   drivers/spi/Kconfig           |   9 +
> >   drivers/spi/Makefile          |   1 +
> >   drivers/spi/spi-spacemit-k1.c | 965 ++++++++++++++++++++++++++++++++++
> >   3 files changed, 975 insertions(+)
> >   create mode 100644 drivers/spi/spi-spacemit-k1.c
> >
> > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> > index 4d8f00c850c14..2e933edab1718 100644
> > --- a/drivers/spi/Kconfig
> > +++ b/drivers/spi/Kconfig
> > @@ -1071,6 +1071,15 @@ config SPI_SG2044_NOR
> >   	  also supporting 3Byte address devices and 4Byte address
> >   	  devices.
> >   
> > +config SPI_SPACEMIT_K1
> > +	tristate "K1 SPI Controller"
> > +	depends on ARCH_SPACEMIT || COMPILE_TEST
> > +	depends on OF
> > +	imply MMP_PDMA if ARCH_SPACEMIT
> > +	default ARCH_SPACEMIT
> SPI needs to be a built-in feature?
> if not, how about:
> default m if ARCH_SPACEMIT

I finally implemented this today and while testing I found a
bug in the module removal code.  It's been more than two weeks
since I got any feedback on this series, and although I've been
holding back on posting I think it's time to send a new version.

In addition to this suggestion, I have two bug fixes plus your
Ack on patch 1, so I just posted v7.

					-Alex