Re: [PATCH 3/4 v3] PCI: s32g: Add initial PCIe support (RC)

From: Christian Bruel

Date: Fri Nov 14 2025 - 05:06:24 EST




The implication is that *every* user of dw_pcie_suspend_noirq() would
have to check for the link being up. There are only three existing
callers:

imx_pcie_suspend_noirq()
ls_pcie_suspend_noirq()
stm32_pcie_suspend_noirq()

but none of them checks for the link being up.


stm32 supports L1.1, so we bail out before pme_turn_off() in dw_pcie_suspend_noirq()


If no devices are attached to the bus, then there is no need to broadcast
PME_Turn_Off and wait for L2/L3. I've just sent out a series that fixes it [1].
Hopefully, this will allow Vincent to use dw_pcie_{suspend/resume}_noirq() APIs.

- Mani

[1] https://lore.kernel.org/linux-pci/20251106061326.8241-1-manivannan.sadhasivam@xxxxxxxxxxxxxxxx/

dw_pcie_suspend_noirq() path tested OK on stm32mp2.

Regards

Christian