Re: [PATCH 3/5] ARM: dts: lpc3250-ea3250: add key- prefix for gpio-keys
From: Vladimir Zapolskiy
Date: Thu Nov 13 2025 - 19:02:43 EST
Hi Frank.
On 10/29/25 22:27, Frank Li wrote:
Add key- prefix to fix below CHECK_DTB warning:
arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dtb: gpio-keys (gpio-keys): 'joy0', ... do not match any of the regexes: '^(button|...)$', 'pinctrl-[0-9]+
Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
---
arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts b/arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts
index 63c6f17bb7c9f..837a3cfa8e7c8 100644
--- a/arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts
+++ b/arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts
@@ -27,55 +27,55 @@ button {
gpios = <&gpio 4 1 0>; /* GPI_P3 1 */
};
- key1 {
+ key-1 {
label = "KEY1";
linux,code = <1>;
gpios = <&pca9532 0 0>;
};
- key2 {
+ key-2 {
label = "KEY2";
linux,code = <2>;
gpios = <&pca9532 1 0>;
};
- key3 {
+ key-3 {
label = "KEY3";
linux,code = <3>;
gpios = <&pca9532 2 0>;
};
- key4 {
+ key-4 {
label = "KEY4";
linux,code = <4>;
gpios = <&pca9532 3 0>;
};
- joy0 {
+ key-joy0 {
label = "Joystick Key 0";
linux,code = <10>;
gpios = <&gpio 2 0 0>; /* P2.0 */
};
- joy1 {
+ key-joy1 {
label = "Joystick Key 1";
linux,code = <11>;
gpios = <&gpio 2 1 0>; /* P2.1 */
};
- joy2 {
+ key-joy2 {
label = "Joystick Key 2";
linux,code = <12>;
gpios = <&gpio 2 2 0>; /* P2.2 */
};
- joy3 {
+ key-joy3 {
label = "Joystick Key 3";
linux,code = <13>;
gpios = <&gpio 2 3 0>; /* P2.3 */
};
- joy4 {
+ key-joy4 {
label = "Joystick Key 4";
linux,code = <14>;
gpios = <&gpio 2 4 0>; /* P2.4 */
Reviewed-by: Vladimir Zapolskiy <vz@xxxxxxxxx>
Thank you for the contributions, I hope I'll find time tomorrow
to send a tiny pull request:
* lpc43xx board compatible strings,
* this change,
* any other your changes with my review comments satisfied, if I get them.
--
Best wishes,
Vladimir