Re: [PATCH v2] efistub: Only link libstub to final vmlinux
From: Josh Poimboeuf
Date: Tue Nov 11 2025 - 13:00:12 EST
On Mon, Nov 10, 2025 at 03:00:00PM +0800, Huacai Chen wrote:
> On Mon, Nov 10, 2025 at 9:19 AM Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> wrote:
> > If I understand correctly, I should modify this patch to remove the
> > changes of arm and riscv for now, do the changes only when there is
> > a real problem or requirement some day, right? If no more comments,
> > I will send v3 later.
>
> Now everyone involved agrees that the efistub code is correct, so the
> proper solution is to fix the compiler.
Hm? I don't see how it's a compiler bug. It's really just an objtool
limitation.
> Changing efistub code and changing objtool (ignore __efistub prefix)
> are both workarounds, but I think changing objtool is a little more
> reasonable. Maybe Josh has different ideas?
I thought the conversation had converged on what Tiezhu mentioned above,
which is to skip objtool on libstub for loongarch, but leave the other
arches alone. That way objtool behavior is consistent between loongarch
and x86, and objtool doesn't need to ignore any prefixes.
So basically, the v2 patch minus the arm64/riscv changes.
--
Josh