Re: [PATCH v5 11/34] random: vDSO: Add explicit includes

From: Jason A. Donenfeld

Date: Fri Nov 07 2025 - 19:00:10 EST


On Thu, Nov 06, 2025 at 11:02:04AM +0100, Thomas Weißschuh wrote:
> Various used symbols are only visible through transitive includes.
> These transitive includes are about to go away.
>
> Explicitly include the necessary headers.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> Tested-by: Andreas Larsson <andreas@xxxxxxxxxxx>
> Reviewed-by: Andreas Larsson <andreas@xxxxxxxxxxx>
> ---
> lib/vdso/getrandom.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/vdso/getrandom.c b/lib/vdso/getrandom.c
> index 440f8a6203a69a6462aafee4ad8d5670cef6a353..7e29005aa208b498b68f16d3df80b048dce8ee21 100644
> --- a/lib/vdso/getrandom.c
> +++ b/lib/vdso/getrandom.c
> @@ -7,8 +7,11 @@
> #include <linux/minmax.h>
> #include <vdso/datapage.h>
> #include <vdso/getrandom.h>
> +#include <vdso/limits.h>
> #include <vdso/unaligned.h>
> +#include <asm/barrier.h>
> #include <asm/vdso/getrandom.h>
> +#include <uapi/linux/errno.h>
> #include <uapi/linux/mman.h>
> #include <uapi/linux/random.h>

Reviewed-by: Jason A. Donenfeld <Jason@xxxxxxxxx>