Re: [PATCH v2] staging: greybus: audio_manager_module: make envp array static const

[Greg Kroah-Hartman]

On Fri, Nov 14, 2025 at 09:40:43AM +0800, Chang Junzheng wrote:
> From: Chang Junzheng <guagua210311@xxxxxxxxxxx>
> 
> Fix checkpatch.pl warning by changing envp array declaration to
> static const char * const. This improves code safety and follows
> kernel coding style recommendations.
> 
> Signed-off-by: Chang Junzheng <guagua210311@xxxxxx>
> ---
> Changes in v2:
> - Restored original indentation of array elements
> - Only changed the array declaration as originally intended
> 
>  drivers/staging/greybus/audio_manager_module.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> index 4a4dfb42f50f..78013d59fc93 100644
> --- a/drivers/staging/greybus/audio_manager_module.c
> +++ b/drivers/staging/greybus/audio_manager_module.c
> @@ -159,14 +159,14 @@ static void send_add_uevent(struct gb_audio_manager_module *module)
>  	char ip_devices_string[64];
>  	char op_devices_string[64];
>  
> -	char *envp[] = {
> -		name_string,
> -		vid_string,
> -		pid_string,
> -		intf_id_string,
> -		ip_devices_string,
> -		op_devices_string,
> -		NULL
> +	static const char * const envp[] = {
> +	name_string,
> +	vid_string,
> +	pid_string,
> +	intf_id_string,
> +	ip_devices_string,
> +	op_devices_string,
> +	NULL

Why did you change the indentation again?

confused,

greg k-h