RE: [Intel-wired-lan] [PATCH v2 10/21] igb: Switch to use %ptSp

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf
> Of Andy Shevchenko
> Sent: Tuesday, November 11, 2025 1:20 PM
> To: Corey Minyard <corey@xxxxxxxxxxx>; Christian König
> <christian.koenig@xxxxxxx>; Dr. David Alan Gilbert
> <linux@xxxxxxxxxxx>; Alex Deucher <alexander.deucher@xxxxxxx>; Thomas
> Zimmermann <tzimmermann@xxxxxxx>; Dmitry Baryshkov
> <dmitry.baryshkov@xxxxxxxxxxxxxxxx>; Rob Clark
> <robin.clark@xxxxxxxxxxxxxxxx>; Brost, Matthew
> <matthew.brost@xxxxxxxxx>; Ulf Hansson <ulf.hansson@xxxxxxxxxx>; Andy
> Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>; Lifshits, Vitaly
> <vitaly.lifshits@xxxxxxxxx>; Manivannan Sadhasivam <mani@xxxxxxxxxx>;
> Niklas Cassel <cassel@xxxxxxxxxx>; Calvin Owens <calvin@xxxxxxxxxx>;
> Vadim Fedorenko <vadim.fedorenko@xxxxxxxxx>; Sagi Maimon
> <maimon.sagi@xxxxxxxxx>; Martin K. Petersen
> <martin.petersen@xxxxxxxxxx>; Karan Tilak Kumar <kartilak@xxxxxxxxx>;
> Hans Verkuil <hverkuil+cisco@xxxxxxxxxx>; Casey Schaufler
> <casey@xxxxxxxxxxxxxxxx>; Steven Rostedt <rostedt@xxxxxxxxxxx>; Petr
> Mladek <pmladek@xxxxxxxx>; Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>;
> Max Kellermann <max.kellermann@xxxxxxxxx>; linux-doc@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; openipmi-
> developer@xxxxxxxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; dri-
> devel@xxxxxxxxxxxxxxxxxxxxx; linaro-mm-sig@xxxxxxxxxxxxxxxx; amd-
> gfx@xxxxxxxxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx;
> freedreno@xxxxxxxxxxxxxxxxxxxxx; intel-xe@xxxxxxxxxxxxxxxxxxxxx;
> linux-mmc@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; intel-wired-
> lan@xxxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-
> s390@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux-
> staging@xxxxxxxxxxxxxxx; ceph-devel@xxxxxxxxxxxxxxx; linux-trace-
> kernel@xxxxxxxxxxxxxxx
> Cc: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>; Sergey Senozhatsky
> <senozhatsky@xxxxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; Sumit
> Semwal <sumit.semwal@xxxxxxxxxx>; Gustavo Padovan
> <gustavo@xxxxxxxxxxx>; David Airlie <airlied@xxxxxxxxx>; Simona Vetter
> <simona@xxxxxxxx>; Maarten Lankhorst
> <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard
> <mripard@xxxxxxxxxx>; Dmitry Baryshkov <lumag@xxxxxxxxxx>; Abhinav
> Kumar <abhinav.kumar@xxxxxxxxx>; Jessica Zhang
> <jesszhan0024@xxxxxxxxx>; Sean Paul <sean@xxxxxxxxxx>; Marijn Suijten
> <marijn.suijten@xxxxxxxxxxxxxx>; Konrad Dybcio
> <konradybcio@xxxxxxxxxx>; De Marchi, Lucas <lucas.demarchi@xxxxxxxxx>;
> Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>; Vivi, Rodrigo
> <rodrigo.vivi@xxxxxxxxx>; Vladimir Oltean <olteanv@xxxxxxxxx>; Andrew
> Lunn <andrew@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@xxxxxxxxx>; Krzysztof Wilczyński
> <kwilczynski@xxxxxxxxxx>; Kishon Vijay Abraham I <kishon@xxxxxxxxxx>;
> Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; Rodolfo Giometti
> <giometti@xxxxxxxxxxxx>; Richard Cochran <richardcochran@xxxxxxxxx>;
> Jonathan Lemon <jonathan.lemon@xxxxxxxxx>; Stefan Haberland
> <sth@xxxxxxxxxxxxx>; Jan Hoeppner <hoeppner@xxxxxxxxxxxxx>; Heiko
> Carstens <hca@xxxxxxxxxxxxx>; Vasily Gorbik <gor@xxxxxxxxxxxxx>;
> Alexander Gordeev <agordeev@xxxxxxxxxxxxx>; Christian Borntraeger
> <borntraeger@xxxxxxxxxxxxx>; Sven Schnelle <svens@xxxxxxxxxxxxx>;
> Satish Kharat <satishkh@xxxxxxxxx>; Baddela, Sesidhar
> <sebaddel@xxxxxxxxx>; James E.J. Bottomley
> <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>; Mauro Carvalho Chehab
> <mchehab@xxxxxxxxxx>; Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>;
> Xiubo Li <xiubli@xxxxxxxxxx>; Ilya Dryomov <idryomov@xxxxxxxxx>;
> Masami Hiramatsu <mhiramat@xxxxxxxxxx>; Mathieu Desnoyers
> <mathieu.desnoyers@xxxxxxxxxxxx>; Andrew Morton <akpm@linux-
> foundation.org>
> Subject: [Intel-wired-lan] [PATCH v2 10/21] igb: Switch to use %ptSp
> 
> Use %ptSp instead of open coded variants to print content of struct
> timespec64 in human readable format.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/igb/igb_ptp.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c
> b/drivers/net/ethernet/intel/igb/igb_ptp.c
> index a7876882aeaf..bd85d02ecadd 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ptp.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ptp.c
> @@ -840,14 +840,11 @@ static void igb_ptp_overflow_check(struct
> work_struct *work)
>  	struct igb_adapter *igb =
>  		container_of(work, struct igb_adapter,
> ptp_overflow_work.work);
>  	struct timespec64 ts;
> -	u64 ns;
> 
>  	/* Update the timecounter */
> -	ns = timecounter_read(&igb->tc);
> +	ts = ns_to_timespec64(timecounter_read(&igb->tc));
> 
> -	ts = ns_to_timespec64(ns);
> -	pr_debug("igb overflow check at %lld.%09lu\n",
> -		 (long long) ts.tv_sec, ts.tv_nsec);
> +	pr_debug("igb overflow check at %ptSp\n", &ts);
> 
>  	schedule_delayed_work(&igb->ptp_overflow_work,
>  			      IGB_SYSTIM_OVERFLOW_PERIOD);
> --
> 2.50.1

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>