Re: [PATCH 6.12 000/562] 6.12.58-rc2 review

[Pavel Machek]

Hi!

> This is the start of the stable review cycle for the 6.12.58 release.
> There are 562 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

I don't believe Sasha or his automation did good job here. It is wrong
to sign-off patches just because of LLM output.

> Takashi Iwai <tiwai@xxxxxxx>
>     ALSA: usb-audio: Add validation of UAC2/UAC3 effect units

If the check triggers, we'll be breaking someone's audio.

> Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
>     net: sh_eth: Disable WoL if system can not suspend

WoL is used for powering up systems, too. Congratulations, this patch
breaks that.

> Li RongQing <lirongqing@xxxxxxxxx>
>     x86/kvm: Prefer native qspinlock for dedicated vCPUs irrespective of PV_UNHALT

Looking at the code, that should really be "goto out".

> Al Viro <viro@xxxxxxxxxxxxxxxxxx>
>     allow finish_no_open(file, ERR_PTR(-E...))

Not sure what bug this is supposed to fix. Sounds like preparation for
something we don't have.

> Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
>     net: macb: avoid dealing with endianness in macb_set_hwaddr()

First, this does not fix any bugs. Second, code was "cpu_to_le32", now
it is equivalent of "le32_to_cpu".

> Arkadiusz Bokowy <arkadiusz.bokowy@xxxxxxxxx>
>     Bluetooth: btusb: Check for unexpected bytes when defragmenting HCI frames

BTUSB_BARROT is "write only". That value is never checked.

Best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature