Re: [RESEND PATCH] Fix ps3disk: use memcpy_{from,to}_bvec index
From: Greg Kroah-Hartman
Date: Sun Nov 16 2025 - 07:14:04 EST
On Fri, Nov 14, 2025 at 03:30:33PM +0100, Rene Rebe wrote:
> With 6e0a48552b8c (ps3disk: use memcpy_{from,to}_bvec) converting
> ps3disk to new bvec helpers, incrementing the offset was accidently
> lost, corrupting consecutive buffers. Restore index for non-corrupted
> data transfers.
>
> Fixes: 6e0a48552b8c (ps3disk: use memcpy_{from,to}_bvec)
>
> Signed-off-by: René Rebe <rene@xxxxxxxxxx>
>
> --- a/drivers/block/ps3disk.c 2023-08-07 17:40:55.200957746 +0200
> +++ b/drivers/block/ps3disk.c 2023-08-07 17:46:39.702964129 +0200
> @@ -85,10 +93,14 @@
> struct bio_vec bvec;
>
> rq_for_each_segment(bvec, req, iter) {
> + dev_dbg(&dev->sbd.core, "%s:%u: %u sectors from %llu\n",
> + __func__, __LINE__, bio_sectors(iter.bio),
In the future, please note that all dev_dbg() calls have __func__ built
into them, and I think __LINE__ as well, so there's no need to ever add
that to the output. Take a look at the documentation for more details
on how to see that in the log.
thanks,
greg k-h