Re: [PATCH] rtc: isl12026: Implement callbacks for alarm feature

[Alexandre Belloni]

On 16/11/2025 10:47:15+0530, Akhilesh Patil wrote:
> > >  static const struct rtc_class_ops isl12026_rtc_ops = {
> > >  	.read_time	= isl12026_rtc_read_time,
> > >  	.set_time	= isl12026_rtc_set_time,
> > > +	.set_alarm	= isl12026_rtc_set_alarm,
> > > +	.read_alarm	= isl12026_rtc_read_alarm,
> > > +	.alarm_irq_enable = isl12026_rtc_alarm_irq_en,
> > >  };
> > >  
> > 
> > This is missing an interrupt handler and proper handling in probe for
> > the wakeup-source property as this seems to be how you use it.
> 
> Agree. However, I thought of first implementing alarm callbacks only and
> test them independedntly using ioctls for alarm settings in this patch.
> I will add interrupt handler and wakeup-source in v2 to complete this
> functionality.

Sure, the issue is that without interrupt handling and wakeup-source,
the driver will behave in a way that will break DT backward
compatibility later on.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com