Re: [PATCH v2] arm64: dts: qcom: x1e80100: Add crypto engine

[Val Packett]

On 2/24/25 12:01 PM, Stephan Gerhold wrote:

> On Fri, Feb 21, 2025 at 03:07:03PM +0200, Abel Vesa wrote:
> > On X Elite, there is a crypto engine IP block similar to ones found on
> > SM8x50 platforms.
> >
> > Describe the crypto engine and its BAM.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > ---
> > The dt-binding schema update for the x1e80100 compatible is here
> > (already picked up):
> >
> > https://lore.kernel.org/all/20250213-dt-bindings-qcom-qce-x1e80100-v1-1-d17ef73a1c12@xxxxxxxxxx/
> > ---
> > [..]
> iommus = <&apps_smmu 0x480 0x1> seems to work fine for me, can you try
> again? Not sure if this is related, but make sure to apply
>
> https://lore.kernel.org/linux-arm-msm/20250208223112.142567-1-caleb.connolly@xxxxxxxxxx/
>
> since that can easily cause crashes for bam_dma. I added this diff for
> testing and it's working fine so far:
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index afb8bd3b6a94..bac3d6a38055 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -3732,8 +3732,7 @@ cryptobam: dma-controller@1dc4000 {
>   
>   			#dma-cells = <1>;
>   
> -			iommus = <&apps_smmu 0x480 0>,
> -				 <&apps_smmu 0x481 0>;
> +			iommus = <&apps_smmu 0x480 0x1>;
>   
>   			qcom,ee = <0>;
>   			qcom,num-ees = <4>;
> @@ -3752,8 +3751,7 @@ crypto: crypto@1dfa000 {
>   			dmas = <&cryptobam 4>, <&cryptobam 5>;
>   			dma-names = "rx", "tx";
>   
> -			iommus = <&apps_smmu 0x480 0>,
> -				 <&apps_smmu 0x481 0>;
> +			iommus = <&apps_smmu 0x480 0x1>;
>   		};
>   
>   		tcsr_mutex: hwlock@1f40000 {

Hi, looks like this has been sort of lost to time but I went to test 
this since the runtime PM patch was for the crypto engine got posted 
recently[1] and I wanted to see if making sure this block goes to sleep 
(vs. whatever state UEFI leaves it in) helps with power consumption 
(can't say it did really..) So,

- iommus = <&apps_smmu 0x480 0x1> does NOT work, breaks the boot 
process, display doesn't initialize etc.;
- the original iommus = <&apps_smmu 0x480 0>, <&apps_smmu 0x481 0> DOES 
attach fine:

[    0.207614] platform 1dfa000.crypto: Adding to iommu group 3


[1]: 
https://lore.kernel.org/all/20251115084851.2750446-1-quic_utiwari@xxxxxxxxxxx/

Thanks,
~val