Re: [PATCH] lockdep: Add header and footer to surround warning reports
From: Tzung-Bi Shih
Date: Sun Nov 16 2025 - 21:44:05 EST
On Sat, Nov 15, 2025 at 05:36:43PM +0100, Geert Uytterhoeven wrote:
> On Fri, 14 Nov 2025 at 07:35, Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -1958,6 +1964,7 @@ print_circular_bug_header(struct lock_list *entry, unsigned int depth,
> > return;
> >
> > pr_warn("\n");
> > + pr_warn(CUT_HERE);
> > pr_warn("======================================================\n");
>
> I guess you can drop all lines printing a separator made of equal signs,
> as CUT_HERE already contains a graphical separator.
I'm not sure if we'd like to maintain the "backward compatibility". I.e.,
if there are already some tools rely on the "====" to parse the report,
should we consider to preserve the equal sign separators?
Happy to receive some more feedback.