Re: [PATCH v5 6/8] media: mediatek: vcodec: fix media device node number

From: Kyrie Wu (吴晗)
Date: Mon Nov 17 2025 - 01:16:16 EST


On Thu, 2025-11-06 at 09:47 -0500, Nicolas Dufresne wrote:
> Hi,
>
> fix -> Fix
>
> Le jeudi 06 novembre 2025 à 14:13 +0800, Kyrie Wu a écrit :
> > change media register device node number to a correct value
>
> You already say that in the subject, the description should explain
> why vfd_dec-
> > minor was wrong.
>
> Nicolas

Dear Nicolas,

I will explain it in the next version.

Thanks.

Regards,
Kyrie
>
>
> >
> > Fixes: 41f03c673cb7b ("media: mediatek: vcodec: replace pr_* with
> > dev_* for
> > v4l2 debug message")
> >
> > Signed-off-by: Kyrie Wu <kyrie.wu@xxxxxxxxxxxx>
> > ---
> > .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c | 3
> > ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv
> > .c
> > b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv
> > .c
> > index fca60e81e3c7..f3e49597602a 100644
> > ---
> > a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv
> > .c
> > +++
> > b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv
> > .c
> > @@ -516,7 +516,8 @@ static int mtk_vcodec_probe(struct
> > platform_device *pdev)
> > goto err_media_reg;
> > }
> >
> > - dev_dbg(&pdev->dev, "media registered as /dev/media%d",
> > vfd_dec->minor);
> > + dev_dbg(&pdev->dev, "media registered as /dev/media%d",
> > + dev->mdev_dec.devnode->minor);
> > }
> >
> > mtk_vcodec_dbgfs_init(dev, false);