Re: [PATCH] arm64: dts: exynos: gs101-pixel: add all S2MPG1x regulators
From: Krzysztof Kozlowski
Date: Mon Nov 17 2025 - 03:14:44 EST
On 13/11/2025 14:31, André Draszik wrote:
> + ldo12m {
> + regulator-name = "vdd_cpucl0_m";
> + regulator-min-microvolt = <700000>;
> + regulator-max-microvolt = <1300000>;
> + regulator-ramp-delay = <6250>;
> + regulator-always-on;
> + samsung,ext-control = <S2MPG10_EXTCTRL_PWREN>;
> + };
> +
> + ldo13m {
> + regulator-name = "vdd_tpu_m";
> + regulator-min-microvolt = <450000>;
> + regulator-max-microvolt = <950000>;
> + regulator-ramp-delay = <12500>;
> + regulator-always-on;
> + samsung,ext-control = <S2MPG10_EXTCTRL_TPU_EN>;
> + };
Please add here brief comment that ldo14m is to be defined per-board.
Same for all other cases which are missing from common DTSI.
> +
> + ldo15m {
> + regulator-name = "vdd_slc_m";
> + regulator-min-microvolt = <450000>;
> + regulator-max-microvolt = <950000>;
> + regulator-ramp-delay = <12500>;
> + regulator-always-on;
> + };
> +
> + ldo16m {
> + regulator-name = "vdd085_pcie0";
> + regulator-min-microvolt = <725000>;
> + regulator-max-microvolt = <1300000>;
> + };
> +
...
> ---
> base-commit: edf57d8dafc63f9298a209e518ea6a2e0df78ed0
> change-id: 20250603-s2mpg1x-regulators-dts-aea4bde3dff9
> prerequisite-change-id: 20250603-s2mpg1x-regulators-7a41c8399abf:v4
> prerequisite-patch-id: 9d4a1e0afe6eb45dcd35a9537b7d5b4e35e801c3
> prerequisite-patch-id: 928fd84e5f6207a2fd98dd8372a91df0776ecfde
> prerequisite-patch-id: b87abb6b9a8fc104f0f752bca0e9347d17de72e0
> prerequisite-patch-id: e053834e5bec411f5c512b63a3528e49aad11ee2
> prerequisite-patch-id: 4fdd195c0b3fea537144ac8d82bb40a38cbde117
> prerequisite-patch-id: cc716fef97d6c25c0589d7269b8f34e04ea96216
> prerequisite-patch-id: 20ff503abaf2fcaef4328e1f8009ed3df242bad3
> prerequisite-patch-id: a0d80e8f49401dd79a7e4dda2517e00228aa3087
> prerequisite-patch-id: 2368af876ec7c643d9765d3fb1e9bc4991023a18
> prerequisite-patch-id: b70d5648790458e72db82e26b180bbd7301469b3
> prerequisite-patch-id: 92be1aa6f95b2a5795df84e11a602e97a41b2938
> prerequisite-patch-id: 86625bb109da618cbb8aef07fa717257918077b8
> prerequisite-patch-id: 2016c6cd5e0d51daddada37232e3b99c8f4ad77b
> prerequisite-patch-id: d323362e84d3991bd949745579aec34897620321
> prerequisite-patch-id: b1571de42ac7dcf0fe8ddb77650a656244ff751b
> prerequisite-patch-id: 44ea2393bc4df716427cbac9b7f080a683ba1c0b
> prerequisite-patch-id: c968c5b557897767bfc2629de79b1ede8ab48767
> prerequisite-patch-id: 221800199a94e12e928dc9606c82b6eb33cffa3a
> prerequisite-patch-id: c76d8055f620e0b5fa81101a31db08fd5a60e773
> prerequisite-patch-id: be0027a934451be02b1c4653bac8b6bc2ae2bd85
This would block this from merging, so then please add RFC prefix. But
probably these are not actual dependencies, so they should not be here.
Best regards,
Krzysztof