Re: [PATCH linux] netfilter: conntrack: Add missing modification about data-race around ct->timeout

[Florian Westphal]

Chenguang Zhao <zhaochenguang@xxxxxxxxxx> wrote:
> Add missing modification about data-race around ct->timeout

This could use a bit more verbose explanation.

>  	   weird delay cases. */
> -	ct->timeout += nfct_time_stamp;
> +	WRITE_ONCE(ct->timeout, ct->timeout + nfct_time_stamp);
                                ~~~~~~~~~~~

Shouldn't that be

WRITE_ONCE(ct->timeout, READ_ONCE(ct->timeout) + nfct_time_stamp); ?

Furthermore, patch subject should list either [nf] or [nf-next] to
indicate the tree you want this patch applied to.