Re: [PATCH 1/1] docs: makefile: move rustdoc check to the build wrapper

[Mauro Carvalho Chehab]

On Mon, Nov 17, 2025 at 10:20:46AM +0100, Miguel Ojeda wrote:
> On Mon, Nov 17, 2025 at 10:13 AM Mauro Carvalho Chehab
> <mchehab+huawei@xxxxxxxxxx> wrote:
> >
> > The makefile logic to detect if rust is enabled is not working
> > the way it was expected. Move it to be inside the wrapper
> > script.
> 
> Hmm... Could the commit explain a bit why this didn't work and why now it does?

I don't know exactly why this was not working.

I guess one of the issues is that the "rustdoc" target becomes
undefined if RUST is not enabled, e.g. rust/Makefile is lacking something
like:

    ifdef CONFIG_RUST
    ...
    else
    rustdoc rustdoc-core rustdoc-macros rustdoc-compiler_builtins:
            $(warning Rust is not enabled. Can't build $<)    
    endif

But this is not enough to explain the issues I'm getting.

Maybe the other issues are cache related.

In any case, here, with Fedora 43, on some cases, when I run:

    make htmldocs  # or make SPHINXDIRS=xxx htmldocs

it sometimes, after building the docs, it tries to run:

    make LLVM=1 rustdoc

as this is not a defined target when CONFIG_RUST is not
present, this causes it to build the entire code.

-- 
Thanks,
Mauro