Re: [PATCH v3 14/14] wifi: ath9k: Remove redundant rcu_read_lock/unlock() in spin_lock
From: Toke Høiland-Jørgensen
Date: Mon Nov 17 2025 - 06:53:03 EST
pengdonglin <dolinux.peng@xxxxxxxxx> writes:
> From: pengdonglin <pengdonglin@xxxxxxxxxx>
>
> Since commit a8bb74acd8efe ("rcu: Consolidate RCU-sched update-side function definitions")
> there is no difference between rcu_read_lock(), rcu_read_lock_bh() and
> rcu_read_lock_sched() in terms of RCU read section and the relevant grace
> period. That means that spin_lock(), which implies rcu_read_lock_sched(),
> also implies rcu_read_lock().
>
> There is no need no explicitly start a RCU read section if one has already
> been started implicitly by spin_lock().
>
> Simplify the code and remove the inner rcu_read_lock() invocation.
>
> Cc: "Toke" <toke@xxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: pengdonglin <pengdonglin@xxxxxxxxxx>
> Signed-off-by: pengdonglin <dolinux.peng@xxxxxxxxx>
Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxx>