Re: [PATCH 2/3] dma: arm-dma350: add support for shared interrupt mode

From: Jun Guo
Date: Mon Nov 17 2025 - 06:59:01 EST



On 11/17/2025 7:32 PM, Robin Murphy wrote:
On 2025-11-17 1:59 am, Jun Guo wrote:
- The arm dma350 controller's hardware implementation varies: some
  designs dedicate a separate interrupt line for each channel, while
  others have all channels sharing a single interrupt.This patch adds
  support for the hardware design where all DMA channels share a
  single interrupt.

We already request the channel interrupts as shared, precisely because
they could well end up muxed to the same physical interrupt line. I
missed that the dedicated combined interrupt output had its own separate
enable, but for that we may as well just set INTREN_ANYCHINTR_EN
unconditionally - the rest of this seems pointless.
I'm not entirely sure if enabling the INTREN_ANYCHINTR_EN bit to 1 would affect the current default scenario where each channel is assigned its own interrupt. The hardware design of the chip I'm currently working with does not support testing the scenario of individual interrupts per channel. If it doesn't cause any issues, I will change it to an unconditional configuration.