Re: [PATCH net-next v2 1/3] net: mdio: move device reset functions to mdio_device.c

From: Buday Csaba
Date: Mon Nov 17 2025 - 07:23:45 EST


On Mon, Nov 17, 2025 at 09:34:49AM +0000, Russell King (Oracle) wrote:
> On Mon, Nov 17, 2025 at 10:28:51AM +0100, Buday Csaba wrote:
> > diff --git a/include/linux/mdio.h b/include/linux/mdio.h
> > index 42d6d47e4..1322d2623 100644
> > --- a/include/linux/mdio.h
> > +++ b/include/linux/mdio.h
> > @@ -92,6 +92,8 @@ void mdio_device_free(struct mdio_device *mdiodev);
> > struct mdio_device *mdio_device_create(struct mii_bus *bus, int addr);
> > int mdio_device_register(struct mdio_device *mdiodev);
> > void mdio_device_remove(struct mdio_device *mdiodev);
> > +int mdio_device_register_gpiod(struct mdio_device *mdiodev);
> > +int mdio_device_register_reset(struct mdio_device *mdiodev);
>
> These are private functions to the mdio code living in drivers/net/phy,
> so I wonder whether we want to have drivers/net/phy/mdio.h for these to
> discourage other code calling these?

I completely agree with that, but that file does not exist yet.
Is it worth creating just for the sake of these two functions?

Csaba