Re: [PATCH v4 1/3] tracing: Have tracer option be instance specific

[Steven Rostedt]

On Mon, 17 Nov 2025 17:03:37 +0100
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> > @@ -5152,12 +5180,14 @@ static int tracing_trace_options_show(struct seq_file *m, void *v)
> >  			seq_printf(m, "no%s\n", trace_options[i]);
> >  	}
> >  
> > -	trace = tr->current_trace;
> > -	if (!trace->flags || !trace->flags->opts)
> > +	flags = tr->current_trace_flags;
> > +	if (!flags || !flags->opts)
> >  		return 0;
> >  
> > -	tracer_flags = tr->current_trace->flags->val;
> > -	trace_opts = tr->current_trace->flags->opts;  
> 
> > +	trace = tr->current_trace;  
> 
> Removing it and this line fixes, but I'm not sure that's correct one, so feel
> free to fold the change or if it will be a fix,
> Reported-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

Thanks for the report. Yeah, that variable is no longer used and can be
removed. I'll send a patch.

-- Steve


> 
> > +	tracer_flags = flags->val;
> > +	trace_opts = flags->opts;