Re: [PATCH] ALSA: au88x0: Fix incorrect error handling for PCI config reads

From: Takashi Iwai
Date: Mon Nov 17 2025 - 11:34:39 EST


On Mon, 17 Nov 2025 07:55:59 +0100,
Haotian Zhang wrote:
>
> __snd_vortex_probe() uses pci_read_config_word() that returns PCIBIOS_*
> codes (positive values on error). However, the function checks 'err < 0'
> which can never be true for PCIBIOS_* codes, causing errors to be silently
> ignored.
>
> Check for non-zero return value and convert PCIBIOS_* codes using
> pcibios_err_to_errno() into normal errno before returning them.
>
> Signed-off-by: Haotian Zhang <vulab@xxxxxxxxxxx>

Applied now. Thanks.


Takashi