Re: [patch V4 03/20] sched/mmcid: Cacheline align MM CID storage

[Mathieu Desnoyers]

On 2025-11-16 15:48, Thomas Gleixner wrote:
[...]
> --- a/include/linux/rseq_types.h
> +++ b/include/linux/rseq_types.h
> @@ -112,7 +112,7 @@ struct sched_mm_cid {
>    */
>   struct mm_cid_pcpu {
>   	unsigned int	cid;
> -};
> +}____cacheline_aligned_in_smp;

Missing space between "}" and "____cacheline_aligned_in_smp".

>   
>   /**
>    * struct mm_mm_cid - Storage for per MM CID data
> @@ -126,7 +126,7 @@ struct mm_mm_cid {
>   	struct mm_cid_pcpu	__percpu *pcpu;
>   	unsigned int		nr_cpus_allowed;
>   	raw_spinlock_t		lock;
> -};
> +}____cacheline_aligned_in_smp;

likewise.

Other than those nits:

Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>

Thanks,

Mathieu


--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com