Re: [RFC 07/10] treewide: rename has_transparent_hugepage() to arch_has_pmd_leaves()

[David Hildenbrand (Red Hat)]

On 06.11.25 22:28, Luiz Capitulino wrote:
> Now that the majority of has_transparent_hugepage() callers have been
> converted to pgtable_has_pmd_leaves(), rename has_transparent_hugepage()
> to arch_has_pmd_leaves() since that's what the helper checks for.
>
> arch_has_pmd_leaves() is supposed to be called only by
> init_arch_has_pmd_leaves(), except for two exeptions:
>
> 1. shmem: shmem code runs very early during boot so it can't use
>     pgtable_has_pmd_leaves()

Can't we just initialize pgtable_has_pmd_leaves() earlier then?

> 2. hugepage_init(): just a temporary exception, this function will be
>     converted in a future commit
>
> Signed-off-by: Luiz Capitulino <luizcap@xxxxxxxxxx>
> ---


[...]

> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index e4c5f70b0a01..02a2772ec548 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -2026,8 +2026,8 @@ static inline bool pgtable_has_pmd_leaves(void)
>   #endif
>   #endif
>   
> -#ifndef has_transparent_hugepage
> -#define has_transparent_hugepage() IS_BUILTIN(CONFIG_TRANSPARENT_HUGEPAGE)
> +#ifndef arch_has_pmd_leaves
> +#define arch_has_pmd_leaves() IS_BUILTIN(CONFIG_TRANSPARENT_HUGEPAGE)
>   #endif

Ah, so it stays for now only set with CONFIG_TRANSPARENT_HUGEPAGE. I 
guess that's something to sort out later :)


--
Cheers

David